Better region markings #490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves(?) the requested region marker so you can actually see the between-base locations, and runs a bar along the selected region.
Here's

ref:0-2
incactus.vg
We have two yellow triangles at the inter-base locations marking the bounds of the requested 0-based end-exclusive region, and a yellow line connecting them. They're also a slightly easier to see yellow than the circles were.
The region indicator, previously and now, matches the BED convention of 0-based, end-exclusive coordinates. But vg is still using 0-based, end-inclusive coordinates to fetch the graph.
I've also restored the scale bar for the Lancet examples, and anything else generated before vg's real subpath support, fixing a regression I made in 3aa66dd. But the Lancet BEDs are non-standardly 1-based (and I think also end-inclusive?), and the provided graphs are describing end-inclusive regions, so when looking at the Lancet examples the coordinates are not using the same convention as usual, and so the region amrker ends a base before the displayed graph.
We can sort out the varying coordinate conventions in a proper solution for #488, which isn't this.