Skip to content

APP-4415: Add machine cost protos to billing endpoint #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2024
Merged

APP-4415: Add machine cost protos to billing endpoint #486

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d00081d
APP-4415: Add machine cost protos to billing endpoint
jr22 Apr 17, 2024
9e29e7d
feedback
jr22 Apr 22, 2024
f6a4dec
Merge branch 'main' into APP-4415
jr22 Apr 22, 2024
73814e3
Merge branch 'main' into APP-4415
jr22 Apr 23, 2024
b9ca52d
empty
jr22 Apr 23, 2024
6f355e4
Built new protos from b9ca52d
github-actions[bot] Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proto/viam/app/v1/billing.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ message GetCurrentMonthUsageResponse {
double discount_amount = 8;
double total_usage_with_discount = 9;
double total_usage_without_discount = 10;
double per_machine_usage_cost = 11;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should somehow indicate whether or not this field is in use for the current customer. There's a risk of ambiguity if someone has a 0 value for this (did not use their machines) versus being on a different model entirely.

So the question is should this billing.proto communicate what fields are in use given the current tier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah agreed it could be ambiguous, but also true of any of the other usage counts in this API now. users can see the breakdown of costs in their invoice (along with the cost per unit). we could also add an a separate endpoint at some point that displays the billing tier information?

}

message GetOrgBillingInformationRequest {
Expand Down