Skip to content

APP-4415: Add machine cost protos to billing endpoint #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2024
Merged

APP-4415: Add machine cost protos to billing endpoint #486

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d00081d
APP-4415: Add machine cost protos to billing endpoint
jr22 Apr 17, 2024
9e29e7d
feedback
jr22 Apr 22, 2024
f6a4dec
Merge branch 'main' into APP-4415
jr22 Apr 22, 2024
73814e3
Merge branch 'main' into APP-4415
jr22 Apr 23, 2024
b9ca52d
empty
jr22 Apr 23, 2024
6f355e4
Built new protos from b9ca52d
github-actions[bot] Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions proto/viam/app/v1/billing.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ message GetCurrentMonthUsageResponse {
double discount_amount = 8;
double total_usage_with_discount = 9;
double total_usage_without_discount = 10;
double monthly_machines_usage_cost = 11;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"monthly" is redundant since "Month" is in the message name

nit: "machine_usage_cost" can be vague as it can mean the sum of above costs. something like "total_per_machine_usage_cost" is clearer to me. I don't feel strongly about this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "total" is a bit confusing because the other fields that start with "total" represent the full total cost whereas this could be one of many SKUs in the future potentially (although i know right now its the only sku applicable for the billing tier with it). made it per_machine_usage_cost instead?

double cost_per_machine_per_month = 12;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field seems unnecessary for the same reason we don't have it for other resources.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatted offline, removing and will omit from FE design as well. users can look at invoice for the sku information like this.

}

message GetOrgBillingInformationRequest {
Expand Down