[APP-3685] feat: add rpc to rename API keys

[mattjperez]

APP-3685: support renaming in API keys list (backend)

Additional rpc and structs needed for app PR, viamrobotics/app/#4520

Changes:

• added to app.proto:

message RenameKeyRequest {
  string id = 1;
  string name = 2;
}

message RenameKeyResponse {
  string id = 1;
  string name = 2;
}

[stevebriskin]

what is this? I would expect an empty response.

[jr22]

you can blame me! i told him above to parrot it back in case we did any stripping of special characters etc and the name was slightly different than whatever was request. if you hate it though, i dont feel strongly so fine to remove.

[mattjperez]

I agreed that it was a good sanity check. Though I didn't think about whether it would conform to the expected behavior of the related rpcs.

[stevebriskin]

Do our other Key api calls change the key "name" if it is invalid?

[ohEmily]

Whoops, will try to un-stall this PR. @mattjperez, please ignore this noise and focus on your new team! :)

@stevebriskin:
CreateKeyResponse above:

message CreateKeyResponse {
  string key = 1;
  string id = 2;
}

i.e. we echo back the provided name and send the newly generated ID.

What if I updated these new RPCs to match a bit better:

message RenameKeyRequest {
  string id = 1;
  string name = 2;
}

message RenameKeyResponse {
  string name = 1;
}

[stevebriskin]

👍

[ohEmily]

Changing RenameKeyResponse to be:

message RenameKeyResponse {
  string id = 1;
  string name = 2;
}

after in person conversation

[kim-mishra]

lgtm!

[ohEmily]

git reset --hard HEAD~1
git merge main

to catch the changes from main that I was missing to hopefully fix the conflicts in generated files 👍

[ohEmily]

Waiting on Julia's PR that fixes the checks on this repo.