Skip to content

is_directory #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

etai-shuchatowitz
Copy link
Member

@etai-shuchatowitz etai-shuchatowitz commented May 9, 2024

@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the safe to test committer is a member of this org label May 9, 2024
@tahiyasalam
Copy link
Member

Wooh, this is perfect! I would recommend creating a corresponding PR in app (and rdk if needed, you can check by seeing if FileInfo is referenced anywhere in the repo). Then, I would configure your app PR to use the API feature branch with the new is_directory boolean. The corresponding updates can be made in app and then we make sure the linters for js and go pass. After the API pr is merged, we can then revert the change that uses your feature branch for API and instead use the newly merged API. This way, the changes between API <> APP are synchronized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants