APP-4896: Implement GetAuthApplication API#506
Conversation
proto/viam/app/v1/end_user.proto
Outdated
| message GetAuthApplicationResponse { | ||
| string application_id = 1; | ||
| string application_name = 2; | ||
| string secret = 3; |
There was a problem hiding this comment.
[minor] maybe we rename to client_secret to match FusionAuth's application.oauthConfiguration.clientSecret from their API? also makes it a little easier to grep for this string.
There was a problem hiding this comment.
yeah makes sense to me. i can also rename the secret field in the RegisterAuthApplication request here to client_secret then?
ohEmily
left a comment
There was a problem hiding this comment.
Thank you! Added a small comment.
|
workflow is broken for api changes -> fixing here |
|
Weird that changing this broke the linter suite. Seems like a linter bug. To unblock your PR you could squash the changes. |
Its a breaking change for me to change the RegisterAuthResponse field from secret -> client_secret so i think this failure is expected? |
Oh what I meant is that it seems dumb to consider it a "breaking" change when it's comparing to an earlier version of the same PR. IMO it should only compare to main, not to the current branch. |
It is comparing to main though. On main the "RegisterAuthApplicationResponse" has "secret" not "client_secret". Maybe im not understanding your q? |
APP-4896
Implementing GetAuthApplication API that will eventually result in CLI command with format: