DATA-3916 Add protos for pipeline tracking #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiepeters
reviewed
Apr 8, 2025
| PipelineExecutionStatus status = 4; | ||
|
|
||
| // The interval the pipeline was run on. | ||
| PipelineDataInterval interval = 5; |
There was a problem hiding this comment.
can we call this data_interval? If we don't want to do data_start_time/data_end_time?
| google.protobuf.Timestamp started = 2; | ||
|
|
||
| // The time the execution was ended. | ||
| google.protobuf.Timestamp ended = 3; |
There was a problem hiding this comment.
Can these be start_time/end_time?
katiepeters
reviewed
Apr 8, 2025
katiepeters
reviewed
Apr 8, 2025
Co-authored-by: Katie Peters <[email protected]>
katiepeters
reviewed
Apr 8, 2025
| // The status of the run. | ||
| PipelineRunStatus status = 6; | ||
|
|
||
| // The reason the run failed, if it did. |
There was a problem hiding this comment.
I probably wouldn't mentioned failure since we wanted it to be more flexible. "An optional message related to the run status"? Maybe?
katiepeters
approved these changes
Apr 8, 2025
vijayvuyyuru
added
the
ready-for-protos
vijayvuyyuru
removed
the
ready-for-protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.