Skip to content

DATA-3916 Remove reason #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
Merged

DATA-3916 Remove reason #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5aec6ce
change values of pagination fields
vijayvuyyuru Apr 8, 2025
a7d11b9
remove token
vijayvuyyuru Apr 8, 2025
1a3df1a
remove reason
vijayvuyyuru Apr 9, 2025
ea2bfe7
Built new protos from 1a3df1a
github-actions[bot] Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 71 additions & 81 deletions app/datapipelines/v1/data_pipelines.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions gen/js/app/datapipelines/v1/data_pipelines_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,6 @@ export class PipelineRun extends jspb.Message {
getStatus(): PipelineRunStatusMap[keyof PipelineRunStatusMap];
setStatus(value: PipelineRunStatusMap[keyof PipelineRunStatusMap]): void;

getReason(): string;
setReason(value: string): void;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): PipelineRun.AsObject;
static toObject(includeInstance: boolean, msg: PipelineRun): PipelineRun.AsObject;
Expand All @@ -466,7 +463,6 @@ export namespace PipelineRun {
dataStartTime?: google_protobuf_timestamp_pb.Timestamp.AsObject,
dataEndTime?: google_protobuf_timestamp_pb.Timestamp.AsObject,
status: PipelineRunStatusMap[keyof PipelineRunStatusMap],
reason: string,
}
}

Expand Down
32 changes: 1 addition & 31 deletions gen/js/app/datapipelines/v1/data_pipelines_pb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3328,8 +3328,7 @@ proto.viam.app.datapipelines.v1.PipelineRun.toObject = function(includeInstance,
endTime: (f = msg.getEndTime()) && google_protobuf_timestamp_pb.Timestamp.toObject(includeInstance, f),
dataStartTime: (f = msg.getDataStartTime()) && google_protobuf_timestamp_pb.Timestamp.toObject(includeInstance, f),
dataEndTime: (f = msg.getDataEndTime()) && google_protobuf_timestamp_pb.Timestamp.toObject(includeInstance, f),
status: jspb.Message.getFieldWithDefault(msg, 6, 0),
reason: jspb.Message.getFieldWithDefault(msg, 7, "")
status: jspb.Message.getFieldWithDefault(msg, 6, 0)
};

if (includeInstance) {
Expand Down Expand Up @@ -3394,10 +3393,6 @@ proto.viam.app.datapipelines.v1.PipelineRun.deserializeBinaryFromReader = functi
var value = /** @type {!proto.viam.app.datapipelines.v1.PipelineRunStatus} */ (reader.readEnum());
msg.setStatus(value);
break;
case 7:
var value = /** @type {string} */ (reader.readString());
msg.setReason(value);
break;
default:
reader.skipField();
break;
Expand Down Expand Up @@ -3473,13 +3468,6 @@ proto.viam.app.datapipelines.v1.PipelineRun.serializeBinaryToWriter = function(m
f
);
}
f = message.getReason();
if (f.length > 0) {
writer.writeString(
7,
f
);
}
};


Expand Down Expand Up @@ -3667,24 +3655,6 @@ proto.viam.app.datapipelines.v1.PipelineRun.prototype.setStatus = function(value
};


/**
* optional string reason = 7;
* @return {string}
*/
proto.viam.app.datapipelines.v1.PipelineRun.prototype.getReason = function() {
return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 7, ""));
};


/**
* @param {string} value
* @return {!proto.viam.app.datapipelines.v1.PipelineRun} returns this
*/
proto.viam.app.datapipelines.v1.PipelineRun.prototype.setReason = function(value) {
return jspb.Message.setProto3StringField(this, 7, value);
};


/**
* @enum {number}
*/
Expand Down
3 changes: 0 additions & 3 deletions proto/viam/app/datapipelines/v1/data_pipelines.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
string next_page_token = 3;
}

message PipelineRun {

Check failure on line 161 in proto/viam/app/datapipelines/v1/data_pipelines.proto

View workflow job for this annotation

GitHub Actions / Test For Lint and Breaking Changes 

Previously present field "7" with name "reason" on message "PipelineRun" was deleted.
// The ID of the run.
string id = 1;

Expand All @@ -176,9 +176,6 @@

// The status of the run.
PipelineRunStatus status = 6;

// An optional message related to the run status.
string reason = 7;
}

enum PipelineRunStatus {
Expand Down
Loading