Skip to content

nick-small-camera-api-change #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicksanford
Copy link
Member

No description provided.

@github-actions github-actions bot added the safe to test committer is a member of this org label Apr 14, 2025
@@ -69,6 +72,10 @@ message GetImageResponse {
message GetImagesRequest {
// Name of a camera
string name = 1;
repeated string desired_source_names = 2;
repeated Format desired_formats = 3;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't do this

@@ -69,6 +72,10 @@ message GetImageResponse {
message GetImagesRequest {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have far-reaching implications accross UIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant