Add Delete data page; reduce overview entry to summary#5027
Open
shannonbradshaw wants to merge 1 commit intoviamrobotics:mainfrom
Open
Add Delete data page; reduce overview entry to summary#5027shannonbradshaw wants to merge 1 commit intoviamrobotics:mainfrom
shannonbradshaw wants to merge 1 commit intoviamrobotics:mainfrom
Conversation
Hoists the "Delete data" how-to out of the data overview into its own page (/data/delete-data/) using the flat Viam app / CLI / Python / Go tabs pattern. The overview page reverts to survey-style: a short summary plus a link, matching the rest of the page's sections. Adds Python and Go code samples for delete_tabular_data, delete_binary_data_by_filter, and delete_binary_data_by_ids that the prose-only SDK section did not have. The new page aliases /data/overview/#delete-data so existing deep-links still work.
❌ Deploy Preview for viam-docs failed. Why did it fail? →
|
viambot
added
the
safe to build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/data/overview/into a dedicated page at/data/delete-data/(weight 27, between Tag data and Filter at the edge).api-keys.mdand the newtag-data.md(PR Add Tag data page #5025).delete_tabular_data,delete_binary_data_by_filter, anddelete_binary_data_by_ids— the SDK story was prose-only before./data/overview/#delete-dataso existing deep-links still resolve.Why
The overview's Delete section was the only H2 on the page that went full how-to with code blocks; every other section (Query, Pipeline, Export, Annotate, Monitor) is a short summary that links to its dedicated page. Pulling Delete out aligns the overview with itself and gives Delete a findable, dedicated page.
Verification
viam-python-sdk/src/viam/app/data_client.py—delete_tabular_data,delete_binary_data_by_filter,delete_binary_data_by_ids.rdk/app/data_client.go:765-802—DeleteTabularData,DeleteBinaryDataByFilter,DeleteBinaryDataByIDs.rdk/cli/app.go:1410-1479(viam data delete binaryfilter set;--tagsis not supported, so the page does not claim it).Test plan
/data/delete-data/renders with the four-tab block and the alias/data/overview/#delete-dataredirects./data/overview/"Delete data" section is a summary, in line with the page's other sections.