APP-6535: only fire clickOutside if click starts and ends outside #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In browsers, if a click
mousedownstarts in one element andmouseupends in another element, theclickevent is fired on the lowest common ancestor of the two elements.MDN - click event
In most cases, this ancestor is going to trigger our
clickOutsidelogic, resulting in frustrating user experiences, especially when selecting text.Change log
Swap
clicklistener formousedownandmouseuplisteners using the same "is target outside?" logic. If and only if both events are outside the target element, the handler is fired