RSDK-9758 - refactor ensureLoggedIn call sites #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensureLoggedInhas turned into a gotcha where everyone adding a new CLI command is responsible for calling it themselves or else risking trying to run actions without being logged in. This feature creates a single canonical call site when a viam client is first created (except when running a login action) so that no one has to think about this anymore!Tested locally after logging out. For non-login actions (e.g.
viam organizations listandviam module generate), being logged out resulted in an error. forviam login, the normal login process proceeded as normal.