Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: RSDK-10311: Switch component #391

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

lia-viam
Copy link
Contributor

Claude-assisted switch component

Currently this does not compile because the buf (or protoc? unclear) gencode sometimes creates namespace switch_ and other times namespace switch, and the latter is not a legal namespace. Will have to figure out a workaround.

@lia-viam lia-viam requested a review from a team as a code owner March 24, 2025 18:24
@lia-viam lia-viam requested review from njooma and stuqdog and removed request for a team March 24, 2025 18:24
@stuqdog
Copy link
Member

stuqdog commented Mar 24, 2025

Currently this does not compile because the buf (or protoc? unclear) gencode sometimes creates namespace switch_ and other times namespace switch, and the latter is not a legal namespace. Will have to figure out a workaround.

@lia-viam fwiw this is how we got around this problem in flutter, I think when we generate the protos we aren't actually compiling yet so something like this should work here as well?

@acmorrow
Copy link
Member

acmorrow commented Apr 7, 2025

Pretty unfortunate that proto doesn't have a better story here. I do see an open issue, so hopefully this can be revisited someday in the future (protocolbuffers/protobuf#10491).

Copy link
Member

@acmorrow acmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CMake parts of this look good to me. Thanks for doing this the right way with CMake, rather than dropping down to unix tools which would have broken my in-progress windows work.

@lia-viam lia-viam merged commit 9c65e45 into viamrobotics:main Apr 7, 2025
4 checks passed
@lia-viam lia-viam deleted the feature/switch branch April 7, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants