Skip to content

try to override b2 #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

try to override b2 #408

wants to merge 2 commits into from

Conversation

lia-viam
Copy link
Contributor

@lia-viam lia-viam commented Apr 9, 2025

@lia-viam lia-viam requested a review from a team as a code owner April 9, 2025 15:30
@lia-viam lia-viam requested review from njooma and stuqdog and removed request for a team April 9, 2025 15:30
stuqdog
stuqdog reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abstractly this looks reasonable to me but tests are failing, so 😢

please re-request review when tests pass and I can look again/approve!

@lia-viam
Copy link
Contributor Author

@stuqdog thanks for taking a look! i am going to close this one, it seems for now that we might be screwed because i don't know if it's possible to override versions of a build dependency for another target. just waiting on developments in the conan ticket for now

@lia-viam lia-viam closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuqdog stuqdog stuqdog left review comments

@njooma njooma Awaiting requested review from njooma njooma is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lia-viam @stuqdog