Add a pg_background_discard_result() function. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function will consume all protocol messages, discard all data and will only rethrow any error data emitted during the background query execution. This allows users to execute any kind of SQL without worrying of specifying a column definition list matching the last emitted resultset if they're not interested in the resultset, but still want to actively wait for the background execution completion and want know if any error happened during the background execution.
|
@vibhorkum as discussed in #39, here's a function to consume all messages and discard everything but the error data. I tried to maintain the previous code as much as it was (so using the ValuePerCall API), and avoid code duplication by simply not executing the SRF API in the discard mode. It just means that the initialization is done in multiple steps, but the code is still straightforward, and I added some comments on top of it. Documentation is also updated and a new regression tests added. Let me know if you have any comment. |
|
Hi @rjuju It looks like you have closed this PR. I was traveling and I missed this. Do you want to re-submit this PR? or are you planning to submit other version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function will consume all protocol messages, discard all data and will only rethrow any error data emitted during the background query execution.
This allows users to execute any kind of SQL without worrying of specifying a column definition list matching the last emitted resultset if they're not interested in the resultset, but still want to actively wait for the background execution completion and want know if any error happened during the background execution.