Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the Target Framework Moniker (TFM) setup by consolidating target framework definitions into a single location and removing conditional SDK version checks. The changes streamline the build configuration by eliminating the separate TargetFrameworks.props file and moving all target framework definitions to Directory.Build.props.
- Consolidated target framework definitions from conditional logic to a single static list
- Removed GitHubActionsTestLogger dependency and its usage
- Eliminated the separate TargetFrameworks.props file in favor of centralized configuration
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/SuperLinq.Tests/SuperLinq.Tests.csproj | Replaced conditional TFM logic with static list, removed GitHubActionsTestLogger |
| Tests/SuperLinq.Async.Tests/SuperLinq.Async.Tests.csproj | Replaced conditional TFM logic with static list, removed GitHubActionsTestLogger |
| TargetFrameworks.props | Deleted file containing conditional TFM definitions |
| SuperLinq.slnx | Removed reference to deleted TargetFrameworks.props file |
| Source/SuperLinq/SuperLinq.csproj | Removed import of TargetFrameworks.props |
| Source/SuperLinq.Async/SuperLinq.Async.csproj | Removed import of TargetFrameworks.props |
| Directory.Packages.props | Removed GitHubActionsTestLogger package version |
| Directory.Build.props | Added centralized target frameworks definition |
| .github/workflows/build.yml | Removed GitHubActions logger from test command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
=========================================
+ Coverage 1.33% 1.34% +0.01%
=========================================
Files 249 249
Lines 8927 8927
Branches 1642 1642
=========================================
+ Hits 119 120 +1
+ Misses 8795 8794 -1
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.