Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rollupjs config #50

Closed
wants to merge 1 commit into from

Conversation

matthiasmiller
Copy link

@matthiasmiller matthiasmiller commented Apr 18, 2021

Fix issues in #44:

  • Resolve crypto issues by setting browser flag
  • Include required commonjs modules
  • Switch rollupjs config from reactdemo output to handtrack.min.js

- Resolve crypto issues by setting browser flag
- Include required commonjs modules
- Switch from reactdemo to handtrack.min.js
@victordibia
Copy link
Owner

Hi @matthiasmiller,

Apologies for missing this useful PR, I was on a trip and did not see this before working on a webpack alternative which has been merged.
Will close this for now, but welcome future contributions. Looking at your solution was really helpful and will be useful for other future rollup projects I work on!

-V.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants