Skip to content

Commit

Permalink
#1 Test fix
Browse files Browse the repository at this point in the history
  • Loading branch information
pabloelcolombiano committed Oct 4, 2022
1 parent 1a54da2 commit dc789a4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fail-fast: false
matrix:
php-version: ['7.4', '8.1']
composer-type: [lowest, stable, dev]
composer-type: [stable, dev]

name: PHP ${{ matrix.php-version }} & ${{ matrix.db-type }} & ${{ matrix.composer-type }}

Expand Down Expand Up @@ -50,9 +50,7 @@ jobs:

- name: Install dependencies
run: |
if [[ ${{ matrix.composer-type }} == 'lowest' ]]; then
composer update --prefer-dist --no-progress --no-suggest --prefer-stable --prefer-lowest
elif [[ ${{ matrix.composer-type }} == 'stable' ]]; then
if [[ ${{ matrix.composer-type }} == 'stable' ]]; then
composer update --prefer-dist --no-progress --no-suggest --prefer-stable
else
composer update --prefer-dist --no-progress --no-suggest
Expand All @@ -62,7 +60,7 @@ jobs:
run: composer sqlite
- name: Run Mysql tests
run: |
sudo service mysql start && mysql -h 127.0.0.1 -u root -proot -e 'CREATE DATABASE IF NOT EXISTS test_fixture_factories;';
sudo service mysql start && mysql -h 127.0.0.1 -u root -proot -e 'CREATE DATABASE IF NOT EXISTS tdc;';
composer mysql
- name: Run Postgres tests
run: composer pgsql
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"require": {
"ext-pdo": "*",
"php": ">=7.3",
"phpunit/phpunit": "^8.5 || ^9.3"
"phpunit/phpunit": "^8.5.23 || ^9.3"
},
"require-dev": {
"cakephp/cakephp-codesniffer": "^4.0",
Expand Down
4 changes: 1 addition & 3 deletions src/ConnectionRegistry.php
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,7 @@ public static function clear(): void
*/
private static function getConnectionCleaner(PDO $pdo, array $ignoredTables): ConnectionCleaner
{
/**
* @var string $driverName
*/
/** @var string $driverName */
$driverName = $pdo->getAttribute(PDO::ATTR_DRIVER_NAME);
switch ($driverName) {
case 'mysql':
Expand Down

0 comments on commit dc789a4

Please sign in to comment.