Skip to content

198-use-shallowref-instead-of-shallowreactive-for-pagecontext-and-data (#198) #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
4350pChris wants to merge 3 commits into
base: main
Choose a base branch
from
Open

198-use-shallowref-instead-of-shallowreactive-for-pagecontext-and-data (#198) #215

4350pChris wants to merge 3 commits into from

Conversation

@4350pChris
Copy link
Member

@4350pChris 4350pChris commented Oct 21, 2025 •
edited by brillout
Loading

I think this is all there is to it.
This is a major breaking change for existing code, as users now have to use .value.

I do think this is the correct approach though.

#198

@4350pChris 4350pChris linked an issue Oct 21, 2025 that may be closed by this pull request
Use shallowRef() instead of shallowReactive() for pageContext and data #198
Open
@4350pChris 4350pChris self-assigned this Oct 21, 2025
@4350pChris 4350pChris added the enhancement ✨ New feature or request label Oct 21, 2025
@pdanpdan
Copy link
Collaborator

pdanpdan commented Oct 21, 2025 •
edited
Loading

What is the benefit of this?
Won't we end up where we started?
#120
#121

@brillout
Copy link
Member

brillout commented Oct 21, 2025

What is the benefit of this?

See #198. WDYT?

@pdanpdan
Copy link
Collaborator

pdanpdan commented Oct 21, 2025

In there it is mentioned Slightly but negligible DX regression, but here it is a huge breaking change

@brillout
Copy link
Member

brillout commented Oct 21, 2025

It is a major breaking change, I agree. Maybe we can attach an AI prompt to the BREAKING CHANGE: release note — these kind of migrations are easy when, for example, using Augment Code. Other than Augment Code, are there other AI tools that can help?

@brillout brillout changed the title 198-use-shallowref-instead-of-shallowreactive-for-pagecontext-and-data 198-use-shallowref-instead-of-shallowreactive-for-pagecontext-and-data (#198) Nov 4, 2025
@brillout
Copy link
Member

brillout commented Nov 4, 2025 •
edited
Loading

How about we postpone this until a user complains about the current approach?

That said, if we can write a good AI prompt for migration, I'd be up to merge this now.

@brillout brillout mentioned this pull request Nov 4, 2025
Open
@brillout
Copy link
Member

brillout commented Dec 9, 2025 •
edited
Loading

Plan:

  • Let's release a new major 0.10.x with this, with AI migration instructions, and a note stating this is the last breaking change before 1.0.0
  • Let's wait a while, see if users complain
  • Let's release 1.0.0

Objections to this plan are welcome.

ETA: sometime in 2026.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brillout brillout Awaiting requested review from brillout

@pdanpdan pdanpdan Awaiting requested review from pdanpdan

Assignees

@4350pChris 4350pChris

Labels

enhancement ✨ New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use shallowRef() instead of shallowReactive() for pageContext and data

4 participants

@4350pChris @pdanpdan @brillout