Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file picker presentation issue in iOS #170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vinceglb
Copy link
Owner

@vinceglb vinceglb commented Dec 11, 2024

Related to #164

Fix the file picker function to work correctly when called in another sheet without causing a presentation error.

  • ContentView.swift

    • Update the sheet modifier to dismiss any currently presented view controller before presenting the picker.
    • Add a check to ensure the picker is not presented on a view controller that is already presenting another view controller.
  • FileKit.ios.kt

    • Update the callPicker function to dismiss any currently presented view controller before presenting the picker.
    • Add a check to ensure the picker is not presented on a view controller that is already presenting another view controller.

For more details, open the Copilot Workspace session.

Related to #164

Fix the file picker function to work correctly when called in another sheet without causing a presentation error.

* **ContentView.swift**
  - Update the `sheet` modifier to dismiss any currently presented view controller before presenting the picker.
  - Add a check to ensure the picker is not presented on a view controller that is already presenting another view controller.

* **FileKit.ios.kt**
  - Update the `callPicker` function to dismiss any currently presented view controller before presenting the picker.
  - Add a check to ensure the picker is not presented on a view controller that is already presenting another view controller.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/vinceglb/FileKit/issues/164?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant