Fix mismatch between floresta-cli
command and florestad
server
#303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where
floresta-cli
was sending agetrawtransaction
command whileflorestad
expected agettransaction
command.The solution updates
floresta-cli
to use thegettransaction
command, aligning it with the Bitcoin reference implementation as outlined in the Bitcoin RPC documentation for thegettransaction
command:Changes made:
Methods::GetRawTransaction
enum variant toMethods::GetTransaction
inmain.rs
.getrawtransaction
togettransaction
.FlorestaRPC
implementation to call the correct method (gettransaction
) inrpc.rs
.README.md
documentation to reflect the new command name.rpc_types.rs
and related files to ensure consistent terminology across the codebase.Impact:
floresta-cli
andflorestad
.Testing Plan:
Manual Testing:
gettransaction
calls work correctly usingfloresta-cli
, returning expected results for valid transaction IDs.Automated Testing:
Closes:
#301