Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite #178

Merged
merged 17 commits into from
Oct 12, 2023
Merged

Rewrite #178

merged 17 commits into from
Oct 12, 2023

Conversation

shenanigansd
Copy link
Contributor

@shenanigansd shenanigansd commented Oct 4, 2023 •
edited
Loading

Small cleanup to make the codebase more consistent and get lints passing.

@shenanigansd shenanigansd self-assigned this Oct 4, 2023
Robin5605
Robin5605 requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@Robin5605 Robin5605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to have a command to push package as well

src/bot/exts/dragonfly/_api.py Outdated Show resolved Hide resolved
src/bot/constants.py Show resolved Hide resolved
@shenanigansd
Remove pylint ignores
70e8e70 
Signed-off-by: GitHub <[email protected]>
@shenanigansd
Wrap Dragonfly API access in a class
db20775 
Signed-off-by: GitHub <[email protected]>
@shenanigansd
Remove the pypi command
7aab9b2 
It will be put back later when actually feasilbe to implement

Signed-off-by: GitHub <[email protected]>
@shenanigansd
Remove outdated env sample
2b6ab17 
Signed-off-by: GitHub <[email protected]>
@shenanigansd
Begin working through Ruff lints
10eaebb 
Signed-off-by: GitHub <[email protected]>
@shenanigansd
Appease the linter
0f3dc20 
Signed-off-by: GitHub <[email protected]>
@shenanigansd shenanigansd marked this pull request as ready for review October 10, 2023 00:36
@shenanigansd
Copy link
Contributor Author

Going ahead and marking this ready for review.
I'd like to get this merged and tagged so any new changes can be reviewed separately and more effectively.
The dependency review failure is fine, we already accept both of those licenses separately.

Robin5605
Robin5605 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Robin5605 Robin5605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall :shipit:

src/bot/__main__.py Show resolved Hide resolved
src/bot/__main__.py Show resolved Hide resolved
@shenanigansd shenanigansd mentioned this pull request Oct 12, 2023
Open
@shenanigansd shenanigansd merged commit 5d3a0a6 into main Oct 12, 2023
@shenanigansd shenanigansd deleted the sd/rewrite branch October 12, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robin5605 Robin5605 Robin5605 approved these changes

Assignees

@shenanigansd shenanigansd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenanigansd @Robin5605