Degree column #296
Merged
Degree column #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This doesn't work for aggregates. Maybe we just disable for aggregates? |
JackWilb
reviewed
Feb 12, 2024
Comment on lines
+20
to
+64
| const sortByDegree = (order: string) => { | ||
| actions.sortBy('Degree', order); | ||
| }; | ||
|
|
||
| const handleOnClick = () => { | ||
| if (sortBy !== 'Degree') { | ||
| sortByDegree('Ascending'); | ||
| } else { | ||
| sortByDegree(sortByOrder === 'Ascending' ? 'Descending' : 'Ascending'); | ||
| } | ||
| }; | ||
|
|
||
| const handleContextMenuClose = () => { | ||
| setContextMenu(null); | ||
| }; | ||
|
|
||
| const getMenuItems = () => [ | ||
| { | ||
| label: 'Sort by Degree - Ascending', | ||
| onClick: () => { | ||
| sortByDegree('Ascending'); | ||
| handleContextMenuClose(); | ||
| }, | ||
| disabled: sortBy === 'Degree' && sortByOrder === 'Ascending', | ||
| }, | ||
| { | ||
| label: 'Sort by Degree - Descending', | ||
| onClick: () => { | ||
| sortByDegree('Descending'); | ||
| handleContextMenuClose(); | ||
| }, | ||
| disabled: sortBy === 'Degree' && sortByOrder === 'Descending', | ||
| }, | ||
| ]; | ||
|
|
||
| const openContextMenu = (e: MouseEvent) => { | ||
| setContextMenu( | ||
| { | ||
| mouseX: e.clientX, | ||
| mouseY: e.clientY, | ||
| id: 'header-menu-degree', | ||
| items: getMenuItems(), | ||
| }, | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Do any of these need useCallback?
JackWilb
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #288
Depends #295
Give a longer description of what this PR addresses and why it's needed
This PR adds a degree column. The column is placed after the bookmark star column. It simply shows a number representing the degree of the row.
The column's header has a
#to represent the degree number. There is a tooltip which says "Degree" onhover. The context menu has the same sorting options (sort ascending, descending)Additionally, this PR adds a left click sort ability to each column as well.
Finally, the sorting accordion is removed from the sidebar entirely.
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
TODOs: