Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deepCopy, hasOwn, emotion, and config files #437

Merged
merged 19 commits into from
Feb 12, 2025

Conversation

JakeWags
Copy link
Member

@JakeWags JakeWags commented Dec 16, 2024

Updates deepCopy documentation to reflect actual usage.

Update structuredClone usage in project to use version-safe deepCopy.

Update instances of Object.hasOwn to prototype version for esnext typescript versioning issues. May be resolved with typescript config changes, however.

Remove extraneous emotion jsx compiler statements (this is included in the tsconfig)

Update configuration files (package.json, tsconfig, vite config) to resolve install-time errors in other environments.

Does this PR close any open issues?

Closes #405

Give a longer description of what this PR addresses and why it's needed

No visible changes to the app, just config updates and some typescript version related changes for compatibility when installed as a node module. This is prep for 1.0 react component release.

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

TODOs:

…. Update configuration files to resolve install-time errors in other environments
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for upset2 failed.

Name Link
🔨 Latest commit 438f25d
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/67abb6d4c981c800085257ec

@JakeWags JakeWags marked this pull request as ready for review December 16, 2024 20:55
Copy link
Contributor

@NateLanza NateLanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakeWags JakeWags self-assigned this Jan 29, 2025
@JackWilb JackWilb merged commit b70d225 into main Feb 12, 2025
0 of 7 checks passed
@JackWilb JackWilb deleted the component-integration-fixes branch February 12, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react component integeration testing
3 participants