Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper ellipsis truncation of set names #443

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

NateLanza
Copy link
Contributor

@NateLanza NateLanza commented Jan 27, 2025

Does this PR close any open issues?

Closes #355

Give a longer description of what this PR addresses and why it's needed

Ensures that an ellipsis is used to truncate set names when the length exceeds the size of the set label above the membership matrix.

Provide pictures/videos of the behavior before and after these changes (optional)

Before:
Screenshot 2025-01-27 at 1 37 50 PM

After:
Screenshot 2025-01-27 at 1 37 19 PM

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit 63c9bfd
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/6797ed1f3f022d00088fa368
😎 Deploy Preview https://deploy-preview-443--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NateLanza NateLanza marked this pull request as ready for review January 27, 2025 22:00
@NateLanza NateLanza self-assigned this Jan 27, 2025
@NateLanza NateLanza requested a review from JakeWags January 27, 2025 22:02
Copy link
Member

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge

@NateLanza NateLanza merged commit 0a4f937 into main Jan 28, 2025
7 checks passed
@NateLanza NateLanza deleted the 355-set-name-truncation branch January 28, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper set name truncation
2 participants