Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-plot tooltips #473

Merged
merged 11 commits into from
Feb 11, 2025
Merged

In-plot tooltips #473

merged 11 commits into from
Feb 11, 2025

Conversation

NateLanza
Copy link
Contributor

Does this PR close any open issues?

Closes #430

Give a longer description of what this PR addresses and why it's needed

  • Adds a tooltip on deviation bars giving the numerical deviation value
  • Adds a tooltip on attribute plots giving Q1, Mean, Median, and Q3

Provide pictures/videos of the behavior before and after these changes (optional)

Before: No tooltips
After:
tooltips

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

@NateLanza NateLanza self-assigned this Feb 7, 2025
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit 9ccdce2
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/67abcb8ce674d9000837771d
😎 Deploy Preview https://deploy-preview-473--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NateLanza NateLanza marked this pull request as ready for review February 7, 2025 19:17
@NateLanza NateLanza requested a review from JakeWags February 7, 2025 19:17
@JakeWags
Copy link
Member

Few things stylistically:

The matrix tooltip should be styled the same. I know that those already existed, but I think it's worthwhile to update the existing ones to match the blue style. I think they currently use title, so it shouldn't be bad to just use the tooltip component.

It looks like the vertical margin from the mouse is increased when hovering over the vega plots, and lesser when hovering over the dot plots (less than 6 items in row). I can't easily capture a screenshot of these, but if you need a screen recording of this specific thing let me know.

Copy link
Member

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Code itself is fine :)

@NateLanza NateLanza merged commit 835a285 into main Feb 11, 2025
7 checks passed
@NateLanza NateLanza deleted the 430-tooltips branch February 11, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In-Plot tooltips
2 participants