-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-plot tooltips #473
In-plot tooltips #473
Conversation
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Few things stylistically: The matrix tooltip should be styled the same. I know that those already existed, but I think it's worthwhile to update the existing ones to match the blue style. I think they currently use It looks like the vertical margin from the mouse is increased when hovering over the vega plots, and lesser when hovering over the dot plots (less than 6 items in row). I can't easily capture a screenshot of these, but if you need a screen recording of this specific thing let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Code itself is fine :)
…into 430-tooltips
…into 430-tooltips
Does this PR close any open issues?
Closes #430
Give a longer description of what this PR addresses and why it's needed
Provide pictures/videos of the behavior before and after these changes (optional)
Before: No tooltips
![tooltips](https://private-user-images.githubusercontent.com/58234814/410718172-7c664dbd-75c9-4bdd-a4d5-cf520e1ac025.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MTE4NjMsIm5iZiI6MTczOTQxMTU2MywicGF0aCI6Ii81ODIzNDgxNC80MTA3MTgxNzItN2M2NjRkYmQtNzVjOS00YmRkLWE0ZDUtY2Y1MjBlMWFjMDI1LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDAxNTI0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRiMjM5ZDM3NDE1ODE4ZjhlYWY2NjhhNDdmOWYzOTkzYmJkZTllMDk4ODdhNzNjMTYxZGRmMGRiZjhiNGE2YjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xFKU4B883jaRAt6LNdlwPigPlXmw2GioAEnkQgOen6o)
After:
Have you added or updated relevant tests?