fix(plugin-vue): handle sourcemap with empty script code#585
Merged
sapphi-red merged 5 commits intomainfrom May 9, 2025
Merged
fix(plugin-vue): handle sourcemap with empty script code#585sapphi-red merged 5 commits intomainfrom
sapphi-red merged 5 commits intomainfrom
Conversation
commit: |
Member
|
I think the linked issue (vuejs/core#13260) is a duplicate of these issues:
and the fix you made on vuejs/core side (vuejs/core#12701) is more ideal. |
Member
Author
|
@sapphi-red
|
sapphi-red
approved these changes
May 7, 2025
Member
sapphi-red
left a comment
There was a problem hiding this comment.
My bad. You're right. Let's add a comment that this part also moves the mappings.
Co-authored-by: 翠 <green@sapphi.red>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close vuejs/core#13260
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).