Fix issues of Playwright 1.49.0

.github/workflows/test.yml

@@ -22,7 +22,7 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
       - run: yarn install
-      - run: yarn playwright-core install chromium
+      - run: yarn playwright-core install chromium --no-shell
       - run: yarn build
       - run: yarn test
   build-and-push-image:

package.json

@@ -12,7 +12,7 @@
     "clean": "shx rm -rf dist tmp",
     "dev": "tsc -w --preserveWatchOutput",
     "example": "yarn --cwd example build",
-    "pretest": "playwright-core install chromium",
+    "pretest": "playwright-core install chromium --no-shell",
     "release": "release-it",
     "release:pre": "release-it --preRelease --npm.tag=next",
     "test": "vitest run --coverage",

src/browser.ts

@@ -44,6 +44,8 @@ export async function launchBrowser({
             '--allow-file-access-from-files',
             disableWebSecurity ? '--disable-web-security' : '',
             disableDevShmUsage ? '--disable-dev-shm-usage' : '',
+            // #357: Set devicePixelRatio=1 otherwise it causes layout issues in HiDPI displays
+            headless ? '--force-device-scale-factor=1' : '',
             // set Chromium language to English to avoid locale-dependent issues (e.g. minimum font size)
             '--lang=en',
             ...(!headless && process.platform === 'darwin'
@@ -63,8 +65,7 @@ export async function launchBrowser({
 }
 
 export function getExecutableBrowserPath(browserType: BrowserType): string {
-  const executable = registry.findExecutable(getBrowserName(browserType))!;
-  return executable.executablePath()!;
+  return playwright[browserType].executablePath();
 }
 
 export function getFullBrowserName(browserType: BrowserType): string {
@@ -80,29 +81,19 @@ export function checkBrowserAvailability(path: string): boolean {
 }
 
 export function isPlaywrightExecutable(path: string): boolean {
-  return registry
-    .executables()
-    .some((exe) => pathEquals(exe.executablePath() ?? '', path));
+  return [playwright.chromium, playwright.firefox, playwright.webkit].some(
+    (exe) => pathEquals(exe.executablePath() ?? '', path),
+  );
 }
 
 export async function downloadBrowser(
   browserType: BrowserType,
 ): Promise<string> {
-  const executable = registry.findExecutable(getBrowserName(browserType))!;
+  const executable = registry.findExecutable(browserType);
   logInfo('Rendering browser is not installed yet. Downloading now...');
   const restartLogging = suspendLogging();
   await registry.install([executable], false);
   logSuccess(`Successfully downloaded browser`);
   restartLogging();
   return executable.executablePath()!;
 }
-
-function getBrowserName(
-  browserType: BrowserType,
-): BrowserType | 'chromium-headless-shell' {
-  if (browserType === 'chromium' && !process.argv[1].endsWith('preview.js')) {
-    return 'chromium-headless-shell';
-  } else {
-    return browserType;
-  }
-}