Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial login form implementation #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

initial login form implementation #21

wants to merge 4 commits into from

Conversation

mmannings
Copy link

Thank you for submitting a pull request! Title this pull request with a brief description of what the pull request fixes/improves/changes. Please describe the pull request in detail using the template below.


Vitro-angular GitHub issue:#20

  • Requires vivo-project/Vitro-angular#[pr-number] (if a REST API PR is required to test this)
  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What's new?

Login page with post request to /api/login (for example: http:localhost/vivo/api/login)

How should this be tested?

A description of what steps someone could take to:

  • Go to <vitro_angular_address>/login (default: localhost:4200/login). Or use button "Login".
  • Provide username and password.
  • Press "Login". if everything's fine you'll be redirected to home path ([""]) and you'll see in a console (F12) writings "Login successful". Otherwise, in a console you'll see error with a status code.

Additional Notes:

This PR is too raw, it needs further revisions.

Interested parties

@wwelling @VeljkoMaksimovic

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • [+] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [+] My PR doesn't introduce circular dependencies
  • [+] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the Vitro-angular License.

@mmannings mmannings requested a review from a user June 16, 2022 14:34
@mmannings
Copy link
Author

William, one question I wanted to ask you. On your screens in slack or from your pull request #19 , I've seen that you don't have any warning or errors in your console regarding CORS. I'm just asking because after starting the project: npm run start and going to localhost:4200, I still see CORS error for the default link http://localhost:8080/api/docs/rest/1
Error is: Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://localhost:8080/api/docs/rest/1. (Reason: CORS request did not succeed). Status code: (null).
Did you do something additionally with the cors-filter, like applying it to the whole Tomcat. Or that's just some of mine own error.

@ghost
Copy link

ghost commented Jun 16, 2022

@SoulsMark I am running VIVO docker compose and have applied the same CORS filter from Vitro web.xml.

@mmannings mmannings removed the request for review from a user June 21, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant