Skip to content

Commit

Permalink
chore(clippy): fix
Browse files Browse the repository at this point in the history
  • Loading branch information
fundon committed Dec 28, 2024
1 parent 4e8100b commit b3bac9f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
7 changes: 5 additions & 2 deletions viz-handlers/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ embed = ["dep:hex", "dep:mime_guess", "dep:http-body-util", "dep:rust-embed"]

prometheus = [
"dep:http-body-util",
"opentelemetry/internal-logs",
"dep:opentelemetry-prometheus",
"dep:prometheus"
"dep:prometheus",
"internal-logs"
]

internal-logs = ["tracing", "opentelemetry/internal-logs"]

[dependencies]
viz-core.workspace = true

Expand All @@ -60,6 +62,7 @@ rust-embed = { workspace = true, optional = true }
opentelemetry = { workspace = true, default-features = false, optional = true }
opentelemetry-prometheus = { workspace = true, optional = true }
prometheus = { workspace = true, optional = true }
tracing = { workspace = true, optional = true }

[dev-dependencies]
tokio = { workspace = true, features = ["rt", "macros"] }
Expand Down
6 changes: 4 additions & 2 deletions viz-handlers/src/prometheus.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
//! [OTEL]: https://docs.rs/opentelemetry-prometheus
use http_body_util::Full;
use opentelemetry::otel_error;
use prometheus::{Encoder, TextEncoder};

use viz_core::{
Expand Down Expand Up @@ -42,7 +41,10 @@ impl Handler<Request> for Prometheus {
if let Err(err) = encoder.encode(&metric_families, &mut body) {
let error = StatusCode::INTERNAL_SERVER_ERROR;
let text = err.to_string();
otel_error!(name: "prometheus_encode_failure", error_code = error.as_u16(), error = text.clone());

#[cfg(feature = "internal-logs")]
opentelemetry::otel_error!(name: "prometheus_encode_failure", error_code = error.as_u16(), error = text.clone());

Err((error, text).into_error())?;
}

Expand Down

0 comments on commit b3bac9f

Please sign in to comment.