Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: fix int prints #23747

Merged
merged 3 commits into from
Feb 17, 2025
Merged

native: fix int prints #23747

merged 3 commits into from
Feb 17, 2025

Conversation

Eliyaan
Copy link
Contributor

@Eliyaan Eliyaan commented Feb 17, 2025

Fix int_to_string overwriting other variables on the stack while creating the string representation of the integer.
(Some of the tests added (the for loop) were going on an infinite loop before.)
Make the size of the lenght variable of arrays allocated with allocate_array independent of the size of the stored items, now 32bits.

Copy link

Connected to Huly®: V_0.6-22162

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@Eliyaan
Copy link
Contributor Author

Eliyaan commented Feb 17, 2025

Sadly the for loop from -2 to 3 does not work yet

@spytheman
Copy link
Member

Sadly the for loop from -2 to 3 does not work yet

no problem, just add it as a commented block + a TODO

@spytheman
Copy link
Member

oh, you did already; excellent

@spytheman spytheman merged commit 7e5b58d into vlang:master Feb 17, 2025
63 of 64 checks passed
@Eliyaan Eliyaan deleted the fix-print-2-ints branch February 17, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants