Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strconv : atou, atou8/16/32/64 function added, with tests. #23766

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

Bruno-Vdr
Copy link
Contributor

@Bruno-Vdr Bruno-Vdr commented Feb 19, 2025

New file in strconv module: atou.v and atou_test.v.

atou / atou32 are provided to keep implementation symmetric with atoi / atoi32.
I choose to partially duplicate code, to avoid parametrizing atoi_common_check
and atoi_common for unsigned case. This choice let the code simpler.

Copy link

Connected to Huly®: V_0.6-22180

@spytheman
Copy link
Member

The remaining CI failures are unrelated, and fixed on master.

@spytheman
Copy link
Member

I choose to partially duplicate code

Good. A little bit of copying is usually better than a little bit of dependency.

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 8b3d02d into vlang:master Feb 20, 2025
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants