-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fire damage Overhaul #2710
base: master
Are you sure you want to change the base?
Fire damage Overhaul #2710
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,8 @@ | |
Think before you code! | ||
Any attempt to code risk class armor will result in a 10 day Github ban.*/ | ||
|
||
/*Developer's note - All LC13 armor has 50% of its red_damage armor as fire armor by default. */ | ||
|
||
/obj/item/clothing/suit/armor/ego_gear/teth | ||
icon = 'icons/obj/clothing/ego_gear/abnormality/teth.dmi' | ||
worn_icon = 'icons/mob/clothing/ego_gear/abnormality/teth.dmi' | ||
|
@@ -25,7 +27,7 @@ Any attempt to code risk class armor will result in a 10 day Github ban.*/ | |
desc = "The archetype was already charred from the moment of extraction. \ | ||
Although the exterior is scorched, it has no adverse effects on the E.G.O’s performance." | ||
icon_state = "match" | ||
armor = list(RED_DAMAGE = 40, WHITE_DAMAGE = -20, BLACK_DAMAGE = -20, PALE_DAMAGE = 0) // 20 | ||
armor = list(RED_DAMAGE = 40, WHITE_DAMAGE = -20, BLACK_DAMAGE = -20, PALE_DAMAGE = 0, FIRE = 30) // 20 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If going by previous logic shouldnt the Match have higher resistance than its red? By default this would be 20 fire resistance but lifetime stew gets double its red resistance? Unless physical resistance and fire resistance are unrelated? Shouldnt all fire resistant armor be equal in its defense against fire since its a out of context issue. I know you dont want people fighting abnormalities with teth armor but it feels weird having one fire abnormality just be weaker than another. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It could be equal, but the idea is to give a little bit more to armors with worse spreads. |
||
|
||
/obj/item/clothing/suit/armor/ego_gear/teth/fragment | ||
name = "fragments from somewhere" | ||
|
@@ -206,7 +208,7 @@ Any attempt to code risk class armor will result in a 10 day Github ban.*/ | |
name = "capote" | ||
desc = "It suffered for such a long time... Unable to do anything about the raging thirst, the flesh endlessly burning and searing." | ||
icon_state = "capote" | ||
armor = list(RED_DAMAGE = 40, WHITE_DAMAGE = -30, BLACK_DAMAGE = -10, PALE_DAMAGE = 0) // 0 | ||
armor = list(RED_DAMAGE = 40, WHITE_DAMAGE = -30, BLACK_DAMAGE = -10, PALE_DAMAGE = 0, FIRE = 30) // 0 | ||
|
||
/obj/item/clothing/suit/armor/ego_gear/teth/fourleaf_clover | ||
name = "four-leaf clover" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,8 @@ | |
Think before you code! | ||
Any attempt to code risk class armor will result in a 10 day Github ban.*/ | ||
|
||
/*Developer's note - All LC13 armor has 50% of its red_damage armor as fire armor by default. */ | ||
|
||
/obj/item/clothing/suit/armor/ego_gear/waw | ||
icon = 'icons/obj/clothing/ego_gear/abnormality/waw.dmi' | ||
worn_icon = 'icons/mob/clothing/ego_gear/abnormality/waw.dmi' | ||
|
@@ -257,7 +259,7 @@ Any attempt to code risk class armor will result in a 10 day Github ban.*/ | |
desc = "Bright as the abnormality it was extracted from, but somehow does not give off any heat. \ | ||
Maybe keep it away from the cold..." | ||
icon_state = "featherofhonor" | ||
armor = list(RED_DAMAGE = 50, WHITE_DAMAGE = 50, BLACK_DAMAGE = 30, PALE_DAMAGE = 10) //140 | ||
armor = list(RED_DAMAGE = 50, WHITE_DAMAGE = 50, BLACK_DAMAGE = 30, PALE_DAMAGE = 10, FIRE = 60) //140 | ||
attribute_requirements = list( | ||
FORTITUDE_ATTRIBUTE = 80, | ||
) | ||
|
@@ -394,7 +396,7 @@ Any attempt to code risk class armor will result in a 10 day Github ban.*/ | |
name = "rimeshank" | ||
desc = "Well, I can't just shiver in the cold forever, can I?" | ||
icon_state = "rimeshank" | ||
armor = list(RED_DAMAGE = 70, WHITE_DAMAGE = 40, BLACK_DAMAGE = 0, PALE_DAMAGE = 30) //140 | ||
armor = list(RED_DAMAGE = 70, WHITE_DAMAGE = 40, BLACK_DAMAGE = 0, PALE_DAMAGE = 30, FIRE = 20) //140 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why does a Waw have a fire resistance of a zayin? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If it was zayin it would have a defense of 10, but it has low fire resistance because its armor made of ice. Just a bit of flavor. |
||
attribute_requirements = list( | ||
FORTITUDE_ATTRIBUTE = 80 | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the fire resistance of this armor double the physical resistance if by default most armor has 50% of its physical resistance as fire resistance.
Shouldn't this be FIRE = 10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normal half is calculated at initialize for most armors. Impending day gets a bonus because the abnormality itself will deal fire damage.