[do-not-merge] website versions multilingual for release v0.1 #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: samzong <[email protected]>
Signed-off-by: samzong <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Signed-off-by: samzong <[email protected]>
…munity and YouTube sections. Signed-off-by: samzong <[email protected]>
Signed-off-by: samzong <[email protected]>
Signed-off-by: samzong <[email protected]>
Collaborator
Author
|
@windsonsea and @my-git9 Hi! Welcome to help Review documents. |
windsonsea
reviewed
Dec 30, 2025
Contributor
There was a problem hiding this comment.
Could we use a shorter folder name like zh rather than current zh-Hans, which is long and has upper-lower case letters.
Collaborator
Author
There was a problem hiding this comment.
zh-Hans is docusaurus's suggested language code.
It is OK to use zh, but there will be ambiguity if zh-Hant(traditional Chinese) is to be supported later.
From my point, I like zh.
windsonsea
reviewed
Dec 30, 2025
Contributor
windsonsea
left a comment
windsonsea
left a comment
There was a problem hiding this comment.
One more concern is:
If someone wants to translate or localize an image located in website/static/img, how should they do it? It may be required to provide some guide.
Signed-off-by: samzong <[email protected]>
Signed-off-by: samzong <[email protected]>
Collaborator
Author
Good Question, And I think next PR to support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for release v0.1, support multi-versions and multilingual.
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews