Skip to content

Conversation

@wjunLu
Copy link
Collaborator

@wjunLu wjunLu commented Jan 4, 2026

What this PR does / why we need it?

Upgrade vllm commit to 0106

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the vLLM commit hash and adapts the code to the changes. The main change is in vllm_ascend/worker/model_runner_v1.py to handle the removal of the maybe_padded_num_tokens argument in _init_model_kwargs. The implementation introduces some code duplication which can be refactored for better maintainability. The changes in the documentation and tests are consistent with the upgrade.

@vllm-ascend-ci vllm-ascend-ci added ready read for review ready-for-test start test by label for PR labels Jan 4, 2026
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions github-actions bot added documentation Improvements or additions to documentation ci/build module:tests labels Jan 4, 2026
@wjunLu wjunLu force-pushed the main0102 branch 4 times, most recently from 713515c to da938d1 Compare January 5, 2026 04:29
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: wjunLu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation merge-conflicts module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants