Skip to content

Conversation

@cookieyyds
Copy link
Contributor

@cookieyyds cookieyyds commented Jan 7, 2026

What this PR does / why we need it?

#5230 this PR introduced a problem when both mtp and full_decode_only are enabled for the DSV32 model, the operators cannot be compiled into the graph. This PR fixes that issue.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug that prevented CUDA graph compilation for the DSV3.2 model when both sequence parallelism (MTP) and the full_decode_only graph mode are enabled. The fix correctly changes the CUDA graph support level reported by the AscendSFAMetadataBuilder from AttentionCGSupport.UNIFORM_SINGLE_TOKEN_DECODE to AttentionCGSupport.UNIFORM_BATCH. This change aligns the SFA attention backend with the MLA backend, enabling graph capture for a wider range of uniform batches. The modification is logical, directly addresses the described problem, and appears to be correct. I approve this change.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@yiz-liu yiz-liu added ready read for review ready-for-test start test by label for PR labels Jan 7, 2026
@yiz-liu yiz-liu merged commit 8b3a7a9 into vllm-project:main Jan 8, 2026
57 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants