Skip to content

Conversation

@starmountain1997
Copy link
Contributor

@starmountain1997 starmountain1997 commented Jan 30, 2026

What this PR does / why we need it?

This PR fixes the single-node nightly test for DeepSeek V3.2 (W8A8) model to ensure CI stability. The changes include:

  1. Simplified nightly test matrix (nightly_test_a3.yaml):
    • Temporarily reduced to only run deepseek3_2-w8a8 test case for debugging
    • Changed trigger from schedule/workflow_dispatch to support push/pull_request for faster iteration
  2. Updated DeepSeek V3.2 test configuration (test_deepseek_v3_2_w8a8.py):
    • Adjusted cudagraph_capture_sizes from [3, 6, 9, 12] to [8, 16, 24, 32] for better performance
    • Increased max-num-seqs from 4 to 8
    • Increased gpu-memory-utilization from 0.92 to 0.98
    • Increased num_speculative_tokens from 2 to 3
  3. Added PR checkout step (_e2e_nightly_single_node.yaml):

Does this PR introduce any user-facing change?

No. This PR only affects CI/CD test configurations and does not introduce any user-facing changes.

How was this patch tested?

The nightly test workflow will run the DeepSeek V3.2 W8A8 test case with the updated configuration to verify the changes work correctly.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the E2E test configuration for the deepseek_v3_2_w8a8 model. The changes include increasing max-num-seqs, adjusting gpu-memory-utilization, updating cudagraph_capture_sizes to align with the new sequence count, and enabling layer sharding for memory optimization. These adjustments appear to be for performance tuning of the test. My review includes one suggestion to remove a commented-out line to improve code clarity.

"8192", "--max-num-seqs", "8", "--trust-remote-code", "--quantization",
"ascend", "--gpu-memory-utilization", "0.98", "--compilation-config",
'{"cudagraph_capture_sizes":[8, 16, 24, 32], "cudagraph_mode":"FULL_DECODE_ONLY"}',
# '{"cudagraph_capture_sizes":[24, 48], "cudagraph_mode":"FULL_DECODE_ONLY"}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This commented-out line appears to be a remnant of testing or debugging. Leaving commented-out code can lead to confusion for future maintainers, who might not know its purpose or whether it should be restored. To improve code clarity and maintainability, it's best to remove this line. If this configuration is important, it should be documented elsewhere or managed through a more explicit configuration mechanism.

@starmountain1997 starmountain1997 force-pushed the cherry-pick-e4713ea9-v0.13.0 branch 2 times, most recently from a161bb1 to 2890b5d Compare January 30, 2026 03:26
@starmountain1997 starmountain1997 changed the base branch from releases/v0.13.0 to main January 30, 2026 03:35
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@starmountain1997 starmountain1997 force-pushed the cherry-pick-e4713ea9-v0.13.0 branch from 2890b5d to 86e59f3 Compare January 30, 2026 03:45
@starmountain1997 starmountain1997 changed the base branch from main to releases/v0.13.0 January 30, 2026 03:47
@starmountain1997 starmountain1997 force-pushed the cherry-pick-e4713ea9-v0.13.0 branch from 86e59f3 to cb1cf22 Compare January 30, 2026 03:48
@wangxiyuan
Copy link
Collaborator

please fix the lint error

@starmountain1997 starmountain1997 force-pushed the cherry-pick-e4713ea9-v0.13.0 branch from cb1cf22 to 53b89a7 Compare January 31, 2026 01:37
@starmountain1997
Copy link
Contributor Author

please fix the lint error

fixed

@starmountain1997 starmountain1997 force-pushed the cherry-pick-e4713ea9-v0.13.0 branch from 53b89a7 to 2a8b3c1 Compare January 31, 2026 02:06
@wangxiyuan wangxiyuan merged commit fae0071 into vllm-project:releases/v0.13.0 Jan 31, 2026
12 checks passed
@starmountain1997 starmountain1997 deleted the cherry-pick-e4713ea9-v0.13.0 branch January 31, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants