Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Jan 30, 2026

What this PR does / why we need it?

The underlying tags for nightly image builds have been corrected, and some useless and confusing workflow fields have been removed.

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: wangli <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the base Docker images for the nightly builds to use the main and main-a3 tags instead of a fixed release version. This change correctly aligns the nightly builds with the latest development code. However, my review highlights a significant risk associated with using floating tags like main. This practice can lead to non-reproducible builds, making it difficult to debug failures caused by the underlying base image. I have recommended switching to immutable tags (e.g., based on commit SHA or date) to enhance the stability and traceability of the build pipeline, which is a high-severity concern for maintaining a robust CI process.

@wangxiyuan wangxiyuan merged commit 8969b94 into vllm-project:main Jan 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants