[0.13.0][cherry-pick]pick from 6310 to fix rope op #6444
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangxiyuan <[email protected]>
wangxiyuan
added
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix for the rotary position embedding (RoPE) operation on Ascend NPUs. The change addresses a bug in handling partial rotary embeddings where rotary_dim is smaller than head_size. The fix correctly passes self.rotary_dim instead of self.head_size to the _npu_rotary_embedding function for the sliced tensors. This ensures the underlying kernel operates on the correct dimension, which is critical for model correctness. The change is accurate and necessary.
starmountain1997
pushed a commit
to starmountain1997/vllm-ascend
that referenced
this pull request
Jan 31, 2026
Pick from vllm-project#6310 to fix rope error for GLM Signed-off-by: wangxiyuan <[email protected]>
SkychenLee
pushed a commit
to SkychenLee/vllm-ascend
that referenced
this pull request
Jan 31, 2026
Pick from vllm-project#6310 to fix rope error for GLM Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: l00832868 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick from #6310 to fix rope error for GLM