-
Notifications
You must be signed in to change notification settings - Fork 789
【main】【bugfix】fix: restrict default MLAPO activation to Decode nodes only #6451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: fems14 <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello @fems14, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug where DeepSeek models failed in a PD mixed environment. The fix primarily involves correcting a typo in the naming of the MLAPO (Multi-Layer Attention Parallelism Optimization) feature and refining the logic for when this feature is enabled, specifically ensuring it's not activated on KV producer instances during decode operations. These changes aim to stabilize the attention mechanism's behavior in complex inference setups. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a runtime failure for DeepSeek models in mixed prefill/decode scenarios. The changes consist of two parts:
- A typo correction, renaming
enabling_malpotoenabling_mlapoacross the codebase for consistency. - A logic refinement in the
enabling_mlapofunction to ensure the MLAPO optimization is only enabled for pure decode instances (i.e., KV cache consumers that are not also producers).
The code changes are correct and effectively resolve the underlying issue.
On a separate note, the pull request title and description do not fully adhere to the repository's style guide.
- The title should use
[]instead of【】and include a[Module]tag (e.g.,[Attention]). - The description sections ('What this PR does / why we need it?', 'How was this patch tested?') should be filled out to provide context for reviewers.
Please update the title and description to align with the contribution guidelines.
Signed-off-by: fems14 <[email protected]>
leo-pony
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: fems14 <[email protected]>
What this PR does / why we need it?
There is an issue with the current default logic for MLAPO (MLA Policy Optimization). By design, MLAPO should only be enabled by default on Decode (D) nodes. However, in hybrid (collocated prefill and decode) scenarios, the strategy is erroneously activated during the Prefill stage.
This PR corrects the default behavior to ensure that MLAPO is exclusively enabled for the Decoding phase. This prevents unexpected policy interference during Prefill and ensures optimal performance in hybrid deployment environments.
Does this PR introduce any user-facing change?
How was this patch tested?