Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Make rotary_embedding ops more flexible with input shape #12777

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Feb 5, 2025

FIX #12729 (comment)

  • Make rotary_embedding ops work with qk having shape of [seq_len, num_heads, head_dim]
  • Clean up deepseek-v2/v3 and mla attention implementation

Copy link

github-actions bot commented Feb 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py marked this pull request as ready for review February 5, 2025 14:09
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I think it would be best to add some TORCH_CHECKs so we don't hit another illegal memory access like you did when running DeepSeek 2VL, but otherwise looks good.

csrc/pos_encoding_kernels.cu Show resolved Hide resolved
csrc/pos_encoding_kernels.cu Show resolved Hide resolved
tests/kernels/test_pos_encoding.py Outdated Show resolved Hide resolved
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants