Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TransformersModel UX #12785

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

hmellor
Copy link
Collaborator

@hmellor hmellor commented Feb 5, 2025

Improve user experience by warning instead of raising when Linear layer cannot be tensor parallelised.

(split from #12776)

Signed-off-by: Harry Mellor <[email protected]>
Copy link

github-actions bot commented Feb 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor changed the title Improve TransformersModel UX Improve TransformersModel UX Feb 5, 2025
self.vocab_size = config.vocab_size
self.unpadded_vocab_size = config.vocab_size

self.model: PreTrainedModel = AutoModel.from_config(
self.config,
attn_implementation="vllm",
torch_dtype=vllm_config.model_config.dtype,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the dtype of the loaded model is handled by a context manager:

with set_default_torch_dtype(model_config.dtype):
with target_device:
model = _initialize_model(vllm_config=vllm_config)

@simon-mo simon-mo merged commit 1a6fcad into vllm-project:main Feb 6, 2025
19 of 22 checks passed
@hmellor hmellor deleted the warn-not-fail branch February 6, 2025 09:34
fxmarty-amd pushed a commit to fxmarty-amd/vllm that referenced this pull request Feb 7, 2025
AoyuQC pushed a commit to AoyuQC/vllm that referenced this pull request Feb 8, 2025
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants