-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TransformersModel
UX
#12785
Improve TransformersModel
UX
#12785
Conversation
Signed-off-by: Harry Mellor <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
self.vocab_size = config.vocab_size | ||
self.unpadded_vocab_size = config.vocab_size | ||
|
||
self.model: PreTrainedModel = AutoModel.from_config( | ||
self.config, | ||
attn_implementation="vllm", | ||
torch_dtype=vllm_config.model_config.dtype, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the dtype of the loaded model is handled by a context manager:
vllm/vllm/model_executor/model_loader/loader.py
Lines 381 to 383 in bc1bdec
with set_default_torch_dtype(model_config.dtype): | |
with target_device: | |
model = _initialize_model(vllm_config=vllm_config) |
Signed-off-by: Felix Marty <[email protected]>
Improve user experience by warning instead of raising when
Linear
layer cannot be tensor parallelised.(split from #12776)