Skip to content

[CI/Build] Fix TPU V1 Test mixed use of & and && across tests #17968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025

Conversation

CAROLZXYZXY
Copy link
Contributor

@CAROLZXYZXY CAROLZXYZXY commented May 11, 2025

Fix buildkite CI errors for tpu v1.

+ docker run --privileged --net host --shm-size=16G -it -e HF_TOKEN= --name tpu-test vllm-tpu /bin/bash -c 'python3 -m pip install git+https://github.com/thuml/depyf.git     && python3 -m pip install pytest pytest-asyncio tpu-info     && python3 -m pip install lm_eval[api]==0.4.4     && export VLLM_XLA_CACHE_PATH=     && export VLLM_USE_V1=1     && export VLLM_XLA_CHECK_RECOMPILATION=1     && echo HARDWARE     && tpu-info     && {         echo TEST_0: Running test_perf.py;         python3 -m pytest -s -v /workspace/vllm/tests/tpu/test_perf.py;         echo TEST_0_EXIT_CODE: $?;     } &     {         echo TEST_1: Running test_compilation.py;         python3 -m pytest -s -v /workspace/vllm/tests/tpu/test_compilation.py;         echo TEST_1_EXIT_CODE: $?;     } &     {         echo TEST_2: Running test_basic.py;         python3 -m pytest -s -v /workspace/vllm/tests/v1/tpu/test_basic.py;         echo TEST_2_EXIT_CODE: $?;     } &     {         echo TEST_3: Running test_accuracy.py::test_lm_eval_accuracy_v1_engine;         python3 -m pytest -s -v /workspace/vllm/tests/entrypoints/llm/test_accuracy.py::test_lm_eval_accuracy_v1_engine;         echo TEST_3_EXIT_CODE: $?;     } &     {         echo TEST_4: Running test_quantization_accuracy.py;         python3 -m pytest -s -v /workspace/vllm/tests/tpu/test_quantization_accuracy.py;         echo TEST_4_EXIT_CODE: $?;     } &     {         echo TEST_5: Running examples/offline_inference/tpu.py;         python3 /workspace/vllm/examples/offline_inference/tpu.py;         echo TEST_5_EXIT_CODE: $?;     } &     {         echo TEST_6: Running test_tpu_model_runner.py;         python3 -m pytest -s -v /workspace/vllm/tests/tpu/worker/test_tpu_model_runner.py;         echo TEST_6_EXIT_CODE: $?;     } &     {         echo TEST_7: Running test_sampler.py;         python3 -m pytest -s -v /workspace/vllm/tests/v1/tpu/test_sampler.py;         echo TEST_7_EXIT_CODE: $?;     } &     {         echo TEST_8: Running test_topk_topp_sampler.py;         python3 -m pytest -s -v /workspace/vllm/tests/v1/tpu/test_topk_topp_sampler.py;         echo TEST_8_EXIT_CODE: $?;     } &     {         echo TEST_9: Running test_multimodal.py;         python3 -m pytest -s -v /workspace/vllm/tests/v1/tpu/test_multimodal.py;         echo TEST_9_EXIT_CODE: $?;     } &     {         echo TEST_10: Running test_pallas.py;         python3 -m pytest -s -v /workspace/vllm/tests/v1/tpu/test_pallas.py;         echo TEST_10_EXIT_CODE: $?;     } &     {         echo TEST_11: Running test_struct_output_generate.py;         python3 -m pytest -s -v /workspace/vllm/tests/v1/entrypoints/llm/test_struct_output_generate.py;         echo TEST_11_EXIT_CODE: $?;     } &     {         echo TEST_12: Running test_moe_pallas.py;         python3 -m pytest -s -v /workspace/vllm/tests/tpu/test_moe_pallas.py;         echo TEST_12_EXIT_CODE: $?;     } &     # Disable the TPU LoRA tests until the feature is activated
    # & {     #     echo TEST_13: Running test_moe_pallas.py;     #     python3 -m pytest -s -v /workspace/vllm/tests/tpu/lora/;     #     echo TEST_13_EXIT_CODE: $?;     # } &     wait     && echo '\''All tests have attempted to run. Check logs for individual test statuses and exit codes.'\'' '
TEST_1: Running test_compilation.py
TEST_2: Running test_basic.py
TEST_3: Running test_accuracy.py::test_lm_eval_accuracy_v1_engine
TEST_4: Running test_quantization_accuracy.py
TEST_5: Running examples/offline_inference/tpu.py
TEST_6: Running test_tpu_model_runner.py
TEST_7: Running test_sampler.py
TEST_8: Running test_topk_topp_sampler.py
TEST_9: Running test_multimodal.py
TEST_10: Running test_pallas.py
TEST_11: Running test_struct_output_generate.py
TEST_12: Running test_moe_pallas.py
+ remove_docker_container
+ docker rm -f tpu-test
tpu-test

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 11, 2025
@mgoin mgoin added tpu Related to Google TPUs ready ONLY add when PR is ready to merge/full CI is needed labels May 12, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for explicit python3

@mergify mergify bot removed the tpu Related to Google TPUs label May 12, 2025
@khluu khluu merged commit b9fd0d7 into vllm-project:main May 12, 2025
67 checks passed
lsy323 pushed a commit to lsy323/vllm that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants