-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Docs] Rename “Distributed inference and serving” to “Parallelism & Scaling” #22466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…caling” Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request renames the 'Distributed inference and serving' documentation page to 'Parallelism & Scaling' and updates links accordingly. The changes are mostly correct, but I've identified a missed link update in docs/models/supported_models.md
which will lead to a broken link. Please see my specific comment for details.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Ricardo Decal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this change. I just had one nit about &
vs and
(I don't have a strong opintion but it did make me wonder)
Signed-off-by: Ricardo Decal <[email protected]>
…caling” (vllm-project#22466) Signed-off-by: Ricardo Decal <[email protected]> Signed-off-by: jingyu <[email protected]>
Purpose
Rename "Distributed inference and serving" page to "Parallelism & Scaling". Future work: factor out cluster setup docs into its own page. Also fixes a broken link to non-existent #running-vllm-on-multiple-nodes section