-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Refactor] Refactor FP8 & INT8 Quant Folder inside 8bit
#22474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Refactor] Refactor FP8 & INT8 Quant Folder inside 8bit
#22474
Conversation
Signed-off-by: yewentao256 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the FP8 and INT8 quantization code into a new 8bit
directory, which improves code organization and maintainability. The changes primarily involve moving files, updating include paths, and cleaning up some comments. The logic appears to be preserved correctly. I have one suggestion regarding a removed comment that provided important context for preventing potential integer overflow issues.
Signed-off-by: yewentao256 <[email protected]>
@mgoin CC |
Purpose
Refactor FP8 & INT8 Quant Folder inside
8bit
for better code maintainabilityTest