-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
[Model] Add Ernie4.5 VL Model Support #22514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: wangyafeng <[email protected]>
Signed-off-by: wangyafeng <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Baidu Ernie4.5 VL model. The changes include new model implementation files, rotary embedding logic, and a custom processor. While the overall structure seems correct, there are several critical issues that need to be addressed. These include hardcoded values that make the code brittle, unsafe tensor operations that could lead to runtime errors, incorrect function calls in the processor, and some incomplete logic indicated by TODOs. Addressing these points will significantly improve the robustness and maintainability of the new model support.
Signed-off-by: wangyafeng <[email protected]>
Signed-off-by: wangyafeng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contritbution! Is this PR ready for review? If not, could you please convert this to a draft PR?
Signed-off-by: wangyafeng <[email protected]>
Signed-off-by: wangyafeng <[email protected]>
Signed-off-by: wangyafeng <[email protected]>
Signed-off-by: wangyafeng <[email protected]>
Signed-off-by: wangyafeng <[email protected]>
@ywang96 Hi, the PR is ready for review. Could you help review it? |
Purpose
Support Baidu Ernie4.5 VL model for vllm
Note: torch.compile is not supported. Due to the model limitations of multimodal experts and text experts, using torch.compile may fail to start