[Model][QwenVL] Simplify cos/sin rotary embedding indexing #28962
+11
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a small followup from #28798 which simplifies the indexing logic. /cc @gcanlin @Isotr0py
For Qwen3VL #28798 slightly changed behaviour where
get_cos_sin()now already returns a GPU tensor. This introduces synchronous CPU to GPU copies ofpos_idswhen using it to index. cc1f0c5 Fixes it by moving the indices onto the GPU in a non-blocking way.Before:


After:
Test Plan
Test Result
Before:
After: