cleanup at::Tag::needs_fixed_stride_order #28974
Open
+20
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boyuan Feng <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes the usage of at::Tag::needs_fixed_stride_order, which was a workaround for a bug in PyTorch 2.6. As the project has upgraded to a newer PyTorch version where this bug is fixed, this cleanup is appropriate and well-executed. The changes are straightforward removals of the legacy tag and its associated definitions, and I found no issues with the implementation.
zou3519
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at::Tag::needs_fixed_stride_orderis a bug in pytorch 2.6 and has been fixed since pytorch 2.7. Since we are on pytorch 2.9.1 now, we cleanup the legacy code.cc @zou3519 @janeyx99