Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TKG-29306] Filter user permission #369

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lubronzhan
Copy link
Contributor

What this PR does / why we need it:

  1. Filter permissions, remove the one that's been deprecated in corresponding AVI Controller version
  2. Add username to user object if it's enterprise license
  3. More logging
    Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

@lubronzhan lubronzhan force-pushed the topic/lubron/test_avi_vc9 branch from 4a2a0d1 to 3a42064 Compare February 5, 2025 04:21
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 15.00000% with 51 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d860f38). Learn more about missing BASE report.
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ollers/akodeploymentconfig/user/user_controller.go 17.64% 42 Missing ⚠️
controllers/akodeploymentconfig/user/ako_role.go 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage        ?   31.91%           
=======================================
  Files           ?       33           
  Lines           ?     3653           
  Branches        ?        0           
=======================================
  Hits            ?     1166           
  Misses          ?     2417           
  Partials        ?       70           
Files with missing lines Coverage Δ
controllers/akodeploymentconfig/user/ako_role.go 0.00% <0.00%> (ø)
...ollers/akodeploymentconfig/user/user_controller.go 9.55% <17.64%> (ø)

@lubronzhan lubronzhan force-pushed the topic/lubron/test_avi_vc9 branch from 3a42064 to 6365671 Compare February 5, 2025 04:24
@lubronzhan lubronzhan force-pushed the topic/lubron/test_avi_vc9 branch from 6365671 to 027955a Compare February 5, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants