Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support showing NSX LB SNAT IP in networkinfo CR #1018

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Support showing NSX LB SNAT IP in networkinfo CR #1018

merged 1 commit into from
Feb 24, 2025

Conversation

timdengyun
Copy link
Contributor

@timdengyun timdengyun commented Jan 27, 2025 •
edited
Loading

Getting VPC policy Tier1 uplink port IP as NSX LB SNAT IP in order to present it in networkinfo CR loadBalancerIPAddresses field.

Test done:

  1. Test for per-created VPC:
    NSX API output for vpc-vw8t for VPC T1 uplink and downlink Port info
GET https://10.192.27.76/policy/api/v1/infra/realized-state/realized-entities?intent_path=/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/vpcs/vpc-vw8t
{
            "extended_attributes": [
                {
                    "data_type": "STRING",
                    "multivalue": true,
                    "values": [
                        "100.64.0.2/31"
                    ],
                    "key": "IpAddresses"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "values": [
                        "02:50:56:56:44:52"
                    ],
                    "key": "MacAddress"
                }
            ],
            "entity_type": "RealizedLogicalRouterPort",
            "intent_paths": [
                "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/vpcs/vpc-vw8t",
                "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/transit-gateways/default"
            ],
            "resource_type": "GenericPolicyRealizedResource",
            "id": "vpc-vw8t",
            "display_name": "default-vpc-vw8t-t0_lrp",
            "path": "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/realized-state/enforcement-points/default/transit-gateways/default/vpc-interfaces/vpc-vw8t",
            "relative_path": "vpc-vw8t",
           ..
        },
{
            "extended_attributes": [
                {
                    "data_type": "STRING",
                    "multivalue": true,
                    "values": [
                        "100.64.0.3/31"
                    ],
                    "key": "IpAddresses"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "values": [
                        "02:50:56:56:44:55"
                    ],
                    "key": "MacAddress"
                }
            ],
            "entity_type": "RealizedLogicalRouterPort",
            "intent_paths": [
                "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/vpcs/vpc-vw8t"
            ],
            "resource_type": "GenericPolicyRealizedResource",
            "id": "gateway-interface",
            "display_name": "default-vpc-vw8t-t1_lrp",
            "path": "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/realized-state/enforcement-points/default/vpcs/vpc-vw8t/gateway-interface",
            "relative_path": "gateway-interface",
                 ..
        },

This PR is to show 100.64.0.3 as loadBalancerIPAddresses SNAT IP for namespace: ns-1 which is associated with VPC vpc-vw8t

kubectl get networkinfo ns-1 -nns-1 -o yaml
apiVersion: crd.nsx.vmware.com/v1alpha1
kind: NetworkInfo
metadata:
  creationTimestamp: "2025-01-21T17:16:23Z"
  generation: 3
  name: ns-1
  namespace: ns-1
  resourceVersion: "5848475"
  uid: 6bb633fc-08c8-4f95-9ca2-829033b6c2b2
vpcs:
- defaultSNATIP: 10.1.0.1
  loadBalancerIPAddresses: 100.64.0.3
  name: vpc-vw8t
  privateIPs:
  - 192.168.0.0/16
  1. Test for per-created VPCs shared by two namespaces.
    The VPC region-1-Default-VPC is shared by two namespaces: ns-1-bm6cc and ns-2-vjzp7， we can see both namespaces have same VPC info in the networkinfo CR.
kubectl get networkinfos ns-1-bm6cc -nns-1-bm6cc -o yaml
apiVersion: crd.nsx.vmware.com/v1alpha1
kind: NetworkInfo
metadata:
  creationTimestamp: "2025-02-19T10:57:10Z"
  generation: 3
  name: ns-1-bm6cc
  namespace: ns-1-bm6cc
  resourceVersion: "9860307"
  uid: fa57669b-f1b9-436c-bacc-0a06dab2738a
vpcs:
- defaultSNATIP: 10.1.0.0
  loadBalancerIPAddresses: 100.64.0.1
  name: region-1-Default-VPC
  privateIPs:
  - 192.173.237.0/24

kubectl get networkinfos ns-2-vjzp7 -nns-2-vjzp7 -o yaml
apiVersion: crd.nsx.vmware.com/v1alpha1
kind: NetworkInfo
metadata:
  creationTimestamp: "2025-02-19T11:09:04Z"
  generation: 3
  name: ns-2-vjzp7
  namespace: ns-2-vjzp7
  resourceVersion: "9860227"
  uid: afbb228c-8741-4f46-980f-8ad0c6ab07d7
vpcs:
- defaultSNATIP: 10.1.0.0
  loadBalancerIPAddresses: 100.64.0.1
  name: region-1-Default-VPC
  privateIPs:
  - 192.173.237.0/24
  1. Test for auto-created VPC by creating namespac ns-3 in VC.
    kubectl get networkinfos ns-3 -nns-3 -o yaml
    apiVersion: crd.nsx.vmware.com/v1alpha1
    kind: NetworkInfo
    metadata:
    creationTimestamp: "2025-02-21T04:54:48Z"
    generation: 2
    name: ns-3
    namespace: ns-3
    resourceVersion: "9862877"
    uid: 86c0b90c-d253-41e1-878f-26d7814d6274
    vpcs:
  • defaultSNATIP: 192.168.0.8
    loadBalancerIPAddresses: 100.64.0.7
    name: ns-3_86c0b90c-d253-41e1-878f-26d7814d6274
    privateIPs:
    • 172.26.0.0/16

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.79245% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.52%. Comparing base (16010be) to head (f821e9a).

Files with missing lines Patch % Lines
.../controllers/networkinfo/networkinfo_controller.go 81.81% 4 Missing ⚠️
pkg/nsx/services/vpc/vpc.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   74.47%   74.52%   +0.05%     
==========================================
  Files         118      118              
  Lines       16285    16330      +45     
==========================================
+ Hits        12128    12170      +42     
- Misses       3389     3391       +2     
- Partials      768      769       +1
Flag Coverage Δ
unit-tests 74.52% <86.79%> (+0.05%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/services/realizestate/realize_state.go 100.00% <100.00%> (ø)
pkg/nsx/services/vpc/vpc.go 55.37% <76.92%> (+0.28%) ⬆️
.../controllers/networkinfo/networkinfo_controller.go 69.05% <81.81%> (+0.94%) ⬆️

@timdengyun timdengyun force-pushed the add_get_nsxlb_snatip branch from ba3170b to bbb2e85 Compare January 27, 2025 18:59
@timdengyun timdengyun mentioned this pull request Feb 5, 2025
Closed
TaoZou1
TaoZou1 reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@TaoZou1 TaoZou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In
Getting VPC Ppolicy -> policy

@zhengxiexie
Copy link
Contributor

/e2e

9 similar comments
@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor

/e2e

@timdengyun
Support showing NSX LB SNAT IP in networkinfo CR
f821e9a 
Getting VPC Ppolicy Tier1 uplink port IP as NSX LB SNAT IP in order to
present it in networkinfo CR loadBalancerIPAddresses field.
@timdengyun
Copy link
Contributor Author

/e2e

1 similar comment
@timdengyun
Copy link
Contributor Author

/e2e

@timdengyun timdengyun merged commit 2bd7c0e into vmware-tanzu:main Feb 24, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantingl dantingl dantingl approved these changes

@TaoZou1 TaoZou1 TaoZou1 approved these changes

@lxiaopei lxiaopei Awaiting requested review from lxiaopei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timdengyun @codecov-commenter @zhengxiexie @dantingl @lxiaopei @TaoZou1